Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get expunged VM data for job result #9949

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR...

Fixes: #9946

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. Haven't tested yet.

@vishesh92 vishesh92 changed the base branch from main to 4.19 November 20, 2024 13:00
@vishesh92
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

The response does not contain removed nics, volumes, etc. But I think it is ok

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11584

@vishesh92 vishesh92 closed this Nov 20, 2024
@vishesh92 vishesh92 reopened this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.10%. Comparing base (a2690e9) to head (a37dc98).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9949      +/-   ##
============================================
- Coverage     15.10%   15.10%   -0.01%     
+ Complexity    11225    11220       -5     
============================================
  Files          5404     5404              
  Lines        473502   473502              
  Branches      57733    57733              
============================================
- Hits          71543    71527      -16     
- Misses       393961   393981      +20     
+ Partials       7998     7994       -4     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.82% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11587

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11787)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9949-t11787-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 417.73 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 472.87 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 387.36 test_vm_life_cycle.py

@DaanHoogland DaanHoogland marked this pull request as ready for review November 25, 2024 09:03
@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11795)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47739 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9949-t11795-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit a73841a into apache:4.19 Nov 28, 2024
26 checks passed
@DaanHoogland DaanHoogland deleted the ghi9946-asyncJobResult branch November 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

destroyVirtualMachine API call with expunge set to true returns null in the response
5 participants