Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义计算总计时, 复制的数据不正确 close #2928 #2937

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 23, 2024 10:23am

@github-actions github-actions bot added the pr(fix) bug fix label Oct 23, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Size Change: +39 B (+0.01%)

Total Size: 330 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 230 kB +39 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.8 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.96 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Oct 23, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 and removed 🚨 test failed 单元测试挂了 labels Oct 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (ecdc9c8) to head (0e5f89b).
Report is 453 commits behind head on next.

Files with missing lines Patch % Lines
...core/src/utils/export/copy/pivot-data-cell-copy.ts 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2937      +/-   ##
==========================================
+ Coverage   75.77%   80.83%   +5.06%     
==========================================
  Files         257      180      -77     
  Lines       11994    10429    -1565     
  Branches     2464     2366      -98     
==========================================
- Hits         9088     8430     -658     
+ Misses       1398      554     -844     
+ Partials     1508     1445      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit f82de36 into next Oct 25, 2024
8 of 9 checks passed
@wjgogogo wjgogogo deleted the fix-2928 branch October 25, 2024 08:17
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
3 participants