Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): 修复操作按钮的 visible 对角头和文本溢出场景不生效 #3001

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

items: [
  {
    key: 'custom-a',
    label: '操作1',
    icon: 'Trend',
    visible: (cell) => {
      return cell instanceof DataCell;
    }
  },
]

🖼️ Screenshot

Before After
image image
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 29, 2024 8:31am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Size Change: +33 B (+0.01%)

Total Size: 617 kB

Filename Size Change
./packages/s2-core/dist/s2.min.js 256 kB +33 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 153 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 merged commit 8f56023 into next Nov 29, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-corner-tooltip branch November 29, 2024 09:01
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants