Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host): Execute kona-client in-process #815

Open
clabby opened this issue Nov 14, 2024 · 1 comment
Open

feat(host): Execute kona-client in-process #815

clabby opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
A-client Area: client binary A-common Area: kona-common crate K-feature Kind: feature

Comments

@clabby
Copy link
Collaborator

clabby commented Nov 14, 2024

Overview

Currently, the kona-host binary shells out to invoke the kona-client binary, rather than executing it in-process. This was done towards the beginning in order to test the kona-preimage API natively in a similar way that the FPVMs use, but there are a few problems:

  • The current BasicKernelInterface::write & BasicKernelInterface::read interfaces take an owned FileDescriptor, which is inflexible for a few reasons:
    • It contains mappings that are invalid on the native architecture or non fault proof VMs (i.e. zkVMs). This is a poor abstraction for re-use.
    • On the NativeIO implementation, we have to take a FileDescriptor type, which is bad for reasons described in feat(common): Improve native IO API #553.
  • The kona-host implementation therefore has to keep the pipe files for the client program alive, in order to guarantee that the pipe remains open for the duration of the asynchronous child process' lifetime.

Instead of doing this, we should change kona-host up so that kona-client runs natively within the process. This will remove the need for the NativeIO entirely in kona-common, and then we can split kona-common into client program utilities and FPVM-specific logic. This should remove the need to solve #553.

@clabby clabby added A-client Area: client binary A-common Area: kona-common crate K-feature Kind: feature labels Nov 14, 2024
@clabby clabby self-assigned this Nov 14, 2024
@samlaf
Copy link
Contributor

samlaf commented Nov 19, 2024

@clabby few questions here as I'm trying to understand how kona works:

  1. First am I thinking correctly about kona that there are 2 ways to run kona-host: as part of FPVM, or natively on hardware (which has goal to produce an rust implementation of op-node)?
  2. Then the goal of this issue is to make the second native hardware mode (is that what the "Online" providers are for?) faster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client binary A-common Area: kona-common crate K-feature Kind: feature
Projects
None yet
Development

No branches or pull requests

2 participants