Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] NACK with a delay #170

Open
Revisor opened this issue Feb 23, 2016 · 4 comments
Open

[Request] NACK with a delay #170

Revisor opened this issue Feb 23, 2016 · 4 comments

Comments

@Revisor
Copy link

Revisor commented Feb 23, 2016

Hi, I'd like to implement retry with an exponential backoff as used in Sidekiq, that is if a job fails it is requeued with an ever longer pause.

Right now if I NACK a job, it returns to the queue immediately. My other option is to ACK the job and add it again, with a delay. This works OK, but from client's point of view it changes the job ID and that makes tracking failed jobs more difficult.

The NACK command with a delay support could look like this:

NACK <job-id> ... <job-id> [DELAY <sec>]

What do you think?

@mtdavidson
Copy link

+1 I thought exactly this. Just being able to adjust the delay on the job without recreating it would be good, but I suppose their are issues related to if its been propagated out to other nodes for processing.

@locked
Copy link

locked commented Jun 9, 2016

+1 would be very nice indeed to have the [DELAY ] argument added to the NACK command

@withings-sas
Copy link

Pull request #188 implements this

@Revisor
Copy link
Author

Revisor commented Jun 10, 2016

Nice, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants