Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More comprehensive test suite #10

Open
anthonyjoeseph opened this issue Mar 30, 2022 · 0 comments · May be fixed by #25
Open

More comprehensive test suite #10

anthonyjoeseph opened this issue Mar 30, 2022 · 0 comments · May be fixed by #25
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@anthonyjoeseph
Copy link
Owner

anthonyjoeseph commented Mar 30, 2022 •
edited
Loading

  • add more complexity to standard 'pathname' test
    • '?', '?left', '?right', and nested sum type
  • rename 'simpleData' -> 'simple', 'data' -> 'complex'
  • Only use tsd for type errors
  • Separate tests for type utilities (Paths, AtPath, Build)
    • use get
  • Separate tests for the monocle file
    • use get
@anthonyjoeseph anthonyjoeseph added enhancement New feature or request good first issue Good for newcomers labels Mar 30, 2022
@anthonyjoeseph anthonyjoeseph linked a pull request Apr 8, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better tests anthonyjoeseph/spectacles-ts
1 participant
@anthonyjoeseph