Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Default GitHub scopes are invasive #159

Closed
nicorikken opened this issue May 24, 2016 · 6 comments
Closed

Default GitHub scopes are invasive #159

nicorikken opened this issue May 24, 2016 · 6 comments
Labels

Comments

@nicorikken
Copy link

The default authorization of Ansible Galaxy for GitHub integration (which is mandatory) is quite invasive. Not yet having deployed my own role, but going from the documentation it seems that there is no actual use for write-access.

The current request:
screen shot 2016-05-24 at 13 47 57

Requesting such extensive scopes, without a clear reason upsets security people, preventing them from publishing to Ansible Galaxy.
This issue directly originates from the remark in CISOfy/lynis-ansible#2

@mmckinst
Copy link

I've run in to this issue too, I don't mind giving ansible galaxy READ permissions to all public repos, but there's no reason for it to have write access.

@chouseknecht
Copy link
Contributor

The scopes are defined here. We ask for 'public_repo' so that you can follow and star repositories from within Galaxy.

@leoarnold
Copy link

@chouseknecht I understand that this was the only way for you to implement GitHub starring in the Galaxy. I'd just like to emphasize that this clearly keeps me from publishing roles in Galaxy, because it is a major security hazard to give Ansible the ability to impersonate me on GitHub and possibly ruin all my reputation publicly and globally. Not that I suspect Ansible of intending this, but what when you get hacked or sold off to some fishy investor?

@mmckinst
Copy link

@leoarnold they've updated the scope to below which seems acceptable to me:

screenshot from 2017-02-10 14-46-04

@leoarnold
Copy link

@mmckinst This is what I get when I try to sign in to the Galaxy at time of this writing and I'm really reluctant to grant "read and write all public repository data".
screenshot_20170211_001454

@mmckinst
Copy link

Weird. I just took a screenshot from https://github.com/settings/applications on my account but I gave galaxy permission for that stuff a long time ago. Back in August 2016 it was requesting more access when I tried to log in which is I how found this bug but at some point between then and now it stopped asking for all the extras perms when I logged in. Maybe there's a difference between new and old accounts? Hopefully someone from ansible will address this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants