-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw cherry-pick of commits: d53e3ed350114e094322162a7984010214acb7e4 … #181
Closed
ipruteanu-sie
wants to merge
1
commit into
ansible-lockdown:devel
from
siemens:siemens/feat/bis5_2_20_Wrong_Value_clientalivecountmax
Closed
Raw cherry-pick of commits: d53e3ed350114e094322162a7984010214acb7e4 … #181
ipruteanu-sie
wants to merge
1
commit into
ansible-lockdown:devel
from
siemens:siemens/feat/bis5_2_20_Wrong_Value_clientalivecountmax
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pruteanu <[email protected]>
1 task
uk-bolly
added a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Merged
uk-bolly
added a commit
that referenced
this pull request
Mar 6, 2024
* Issue #170, PR #181 thanks to @ipruteanu-sie * issue #182, PR #183 thansk to @ipruteanu-sie * PR #180 thanks to @ipruteanu-sie and @raabf * Addressed PR #165 thanks to @ipruteanu-sie * PT #184 addressed thansk to @ipruteanu-sie * updated credits * typo and ssh allow_deny comments * enable OS check --------- Signed-off-by: Mark Bolwell <[email protected]>
ipruteanu-sie
pushed a commit
to siemens/RHEL9-CIS
that referenced
this pull request
Mar 11, 2024
* Issue ansible-lockdown#170, PR ansible-lockdown#181 thanks to @ipruteanu-sie * issue ansible-lockdown#182, PR ansible-lockdown#183 thansk to @ipruteanu-sie * PR ansible-lockdown#180 thanks to @ipruteanu-sie and @raabf * Addressed PR ansible-lockdown#165 thanks to @ipruteanu-sie * PT ansible-lockdown#184 addressed thansk to @ipruteanu-sie * updated credits * typo and ssh allow_deny comments * enable OS check --------- Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Pruteanu <[email protected]>
This is part of |
uk-bolly
added a commit
that referenced
this pull request
Apr 15, 2024
* Issue #170, PR #181 thanks to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * issue #182, PR #183 thansk to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * PR #180 thanks to @ipruteanu-sie and @raabf Signed-off-by: Mark Bolwell <[email protected]> * Addressed PR #165 thanks to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * PT #184 addressed thansk to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * updated credits Signed-off-by: Mark Bolwell <[email protected]> * typo and ssh allow_deny comments Signed-off-by: Mark Bolwell <[email protected]> * enable OS check Signed-off-by: Mark Bolwell <[email protected]> * PR - #198 addressed thanks to @brakkio86 Signed-off-by: Mark Bolwell <[email protected]> * Addressed issue #190 Signed-off-by: Mark Bolwell <[email protected]> * Additional vars for issue #190 Signed-off-by: Mark Bolwell <[email protected]> * updated pre-commit version Signed-off-by: Mark Bolwell <[email protected]> * consistent quotes around mode Signed-off-by: Mark Bolwell <[email protected]> * moved audit added discoveries Signed-off-by: Mark Bolwell <[email protected]> * removed unneeded vars Signed-off-by: Mark Bolwell <[email protected]> * audit moved to prelim Signed-off-by: Mark Bolwell <[email protected]> * tidy up Signed-off-by: Mark Bolwell <[email protected]> * improved new variable usage Signed-off-by: Mark Bolwell <[email protected]> * fixed logic 6.2.10 Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * addressed #197 thanks to @mark-tomich Signed-off-by: Mark Bolwell <[email protected]> * updates for audit section Signed-off-by: Mark Bolwell <[email protected]> * fixed naming Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * added prelim to includes Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Recreation of this PR as DCO fails when re-basing.
Basically, it emulates a cherry pick of the two previous commits.
Issue Fixes:
#170
Enhancements:
CountAliveCountMax: 0 -> 3
ClientAliveInterval: 900 - > 15 # (as agreed on the initial PR with @uk-bolly)
How has this been tested?:
N/A