Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_bucket - fix MethodNotAllowed in regions that don't support transfer acceleration #2267

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 29, 2024

fixes: #2266

SUMMARY

While #2202 (combined with #2222) fixes the issue for the aws-gov partition, the aws partition throws a different Error (MethodNotAllowed).

I suspect the two different exceptions are a side effect of how AWS implement the Gov-Cloud partition vs the normal partition.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

See also: #2266

@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 29, 2024
@tremble tremble added this to the 8.2.0 milestone Aug 29, 2024
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d1e9e7890ae346ae9c8698c848662108

✔️ ansible-galaxy-importer SUCCESS in 3m 37s
✔️ build-ansible-collection SUCCESS in 10m 53s
✔️ ansible-test-splitter SUCCESS in 4m 24s
✔️ integration-amazon.aws-1 SUCCESS in 7m 39s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 29, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7825f2a228da47f8aab1b82bae3a7a68

✔️ ansible-galaxy-importer SUCCESS in 5m 26s
✔️ build-ansible-collection SUCCESS in 10m 35s
✔️ ansible-test-splitter SUCCESS in 4m 18s
✔️ integration-amazon.aws-1 SUCCESS in 5m 42s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit db552aa into ansible-collections:main Aug 29, 2024
37 checks passed
Copy link

patchback bot commented Aug 29, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/db552aa17f2056d91e7e4545b55ce14883674b45/pr-2267

Backported as #2269

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 29, 2024
…er acceleration (#2267)

fixes: #2266
SUMMARY
While #2202 (combined with #2222) fixes the issue for the aws-gov partition, the aws partition throws a different Error (MethodNotAllowed).
I suspect the two different exceptions are a side effect of how AWS implement the Gov-Cloud partition vs the normal partition.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
See also: #2266

Reviewed-by: GomathiselviS
(cherry picked from commit db552aa)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 29, 2024
…er acceleration (#2267) (#2269)

This is a backport of PR #2267 as merged into main (db552aa).
fixes: #2266
SUMMARY
While #2202 (combined with #2222) fixes the issue for the aws-gov partition, the aws partition throws a different Error (MethodNotAllowed).
I suspect the two different exceptions are a side effect of how AWS implement the Gov-Cloud partition vs the normal partition.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
See also: #2266

Reviewed-by: Mark Chappell
@vonschultz
Copy link

Works for me. Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3_bucket module always fails in eu-north-1
3 participants