A new workflow to ease pull request review by labelling them #2153
Conversation
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 36s |
|
Hi @abikouo Thank you for the effort you put into creating a GH workflow to ease PR review by labeling the PR based on its size. This is a fantastic step towards improving our review process. However, I would like to note that while this workflow can inform the PR submitter about the need to break down large PRs, we should be cautious about relying solely on the formula used. The PR size should ideally reflect the complexity of the inserted and deleted lines, not just their count. The current formula may not fully capture this complexity. Thank you again for your contribution. Your work is much appreciated, and this workflow will certainly help streamline our PR submission and review process. Can you add a proposal in the cloud-content-handbook and move the GH action to cloud-content-ci-automation repository? |
There was a problem hiding this comment.
As @GomathiselviS suggested, I think this approach should first be proposed in the content handbook.
|
|
||
| def LabelCommentPR(repository: str, pr_number: int, insertions: int, deletions: int) -> None: | ||
| # Calculating PR Size: | ||
| # The PR size is calculated using the formula: insertions + deletions * 0.5. |
There was a problem hiding this comment.
Where this formula is coming from?
SUMMARY Depends-On: ansible-collections#2303 Refactor ec2_vpc_peer* modules Once the module is migrated to amazon.aws I will deprecate result returned by the info module and rename the ec2_vpc_peer module (see ansible-collections#2154). ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_vpc_peer ec2_vpc_peering_info ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fcd780e
SUMMARY Depends-On: ansible-collections#2303 Refactor ec2_vpc_peer* modules Once the module is migrated to amazon.aws I will deprecate result returned by the info module and rename the ec2_vpc_peer module (see ansible-collections#2154). ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_vpc_peer ec2_vpc_peering_info ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fcd780e
SUMMARY Depends-On: ansible-collections#2303 Refactor ec2_vpc_peer* modules Once the module is migrated to amazon.aws I will deprecate result returned by the info module and rename the ec2_vpc_peer module (see ansible-collections#2154). ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_vpc_peer ec2_vpc_peering_info ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fcd780e
This new workflow calculates the size of a pull request based on the additions and deletions and add a label corresponding to the size of the pull (XS, S, M, L, XL).
This aims to ease pull request review