Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.40.0 rc #3486

Merged
merged 232 commits into from
Jul 5, 2024
Merged

0.40.0 rc #3486

merged 232 commits into from
Jul 5, 2024

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

murisi and others added 30 commits May 28, 2024 12:29
* origin/brent/remove-max-sigs:
  changelog: add #3380
  remove check for maximum number of signatures per tx
* origin/grarco/vectorize-transfers:
  Changelog #3356
  Fmt
  Avoids reloading shielded context
  Misc improvements to signing for vectorized transfers
  Check no vectorized transfers in cli
  Fixes signature generation for vectorized transfers
  Fixes benchmarks
  Vectorizes masp transfers
  Vectorizes transparent transfers
* origin/tomas/masp-total-rewards:
  changelog: add #3375
  client/rpc: print MASP total rewards in conversions query
  sdk: add a query for MASP total rewards
  shielded_token: store the total rewards minted by MASP
* origin/fraccaman/remove-multipler-check-governance:
  changelog: add #3390
  some small changes
  minors
  minors
  remove epoch multipler check for governance
* origin/tiago/test-batch-tx-events:
  Changelog for #3401
  Test inner tx results from batch tx
  Remove redundant TODO
* origin/tiago/remove-max-block-time-param:
  Changelog for #3366
  Adjust IBC timeout values
  Clue IBC max block time estimate from Namada params
  Decrease max block time estimate to 1m
  update Hermes
  Add additional test coverage for max expected block times
  Import `namada_storage` with `testing` feat
  Avoid estimating block time of zero
  Test max block time estimates
  Insert mock block headers into test storage
  Split out `estimate_max_block_time_from_parameters`
  Remove max expected block time param
  Retrieve max block time estimate from new rpc method in masp
  Add max block duration estimate rpc method
  Read epochs per year param
  Implement date time subtraction
  Add block header Namada rpc handler
…0' (#3409)

* origin/murisi/masp-ibc-replay-protection-using-txdata-on-0.39.0:
  Added changelog entry.
  Update balances in the MASP using a non-mutating style.
  Now charge gas in IBC denom query.
  Start using IBC ports to determine message formats.
  Added more comments and improved function naming.
  Simplify checking packet acknowledgement by assuming the uniqueness of the success acknowledgement.
  Removed is_any_shielded_action_balance_key and related code since thats no longer used.
  Now map denominations to tokens using ibc_token instead of reverse_query_denom.
  Subdivided some functions involved in processing IBC packets.
  Reduced the dependence on IBC events.
  Ensure that native tokens can always be decoded.
  Handle the is_sender_chain_source case in the MASP VP.
  Centralized the construction of TransparentAddresses to ensure that encodings are consistent.
  Split up the IBC validation logic in MASP.
  Now check that the IBC events are valid with respect to storage changes.
  Created a separate type that is either an Address or IBC receiver.
  Modified the MASP VP to check the IBC receivers.
  Now hash the TransferTarget into Transaction transparent outputs.
* origin/tiago/consistent-datetime-serialization:
  Changelog for #3389
  Regen tx fixtures
  Resign localnet genesis txs
  Rebuild wasms for tests
  gen_localnet.py: Fix genesis time string
  Increase precision of timestamps to 9 nanos
  Fix genesis time in tests
  Keep nanoseconds during CometBFT time conversions
  Switch to fixed offset format in UTC
  Increase robustness of datetime test
  Improve tx salting
  Fix from tm time impl for `DateTimeUtc`
  Misc fixes
  Increase gas limit in `FinalizeBlock` tests
  Add datetime encoding tests
  Enforce fixed RFC3339 format
* origin/tiago/uniquely-identify-inner-txs:
  Changelog for #3416
  Re-export `either` from `namada_tx`
  Derive inner tx hash using wrapper hash
* origin/yuji/fix-ibc-message-decoding:
  add changelog
  decode transfer and NFT transfer messages
* origin/bat/feat/db-snapshots:
  addressing review comment
  review comments
  Update crates/node/src/storage/rocksdb.rs
  Update crates/node/src/storage/rocksdb.rs
  changelog
  [feat]: Added snapshot frequency to config
  [feat]: Added ability to create snapshots of rocksDb
  WIP
* origin/murisi/upgrade-ledger-namada-rs-dep:
  Added changelog entry.
  Upgrade ledger-namada-rs to 0.0.24.
* origin/bat/feat/list-and-offer-snapshots:
  rebasing
  tinies
  Added changelog
* origin/fraccaman/limit-pgf-stewards:
  changelog: add #3442
  cleanup
  bug fix: get correct storage key
  fix genesis files
  improve logs
  added maximum amount of stewards as genesis parameter
* origin/grarco/sdk-query-height:
  Changelog #2891
  Fallible trait bound for block height param in queries
* origin/brent/parameterize-gas-scale:
  Updated example of expected string
  Fixes ibc e2e test
  fix unit test
  change comment on Gas Display
  fixes from comments
  changelog: add #3391
  fix and clean up
  Light error handling
  remove hard-coded gas scale
  add gas scale to protocol params
* origin/tomas/move-verify-shielded:
  changelog: add #3419
  shielded_token: feature guard validation to avoid compilation into wasm
  move masp validation from SDK into shielded_token crate
* origin/grarco/masp-fee-payment:
  Removes fallback logic when failed fee payment
  Renames misleading gas limit variable
  Removes useless write-log commit in fee payment
  Fixes typo
  Fixes masp amounts conversion
  Fixes broken docs
  Reuses token transfer
  Fixes typo
  Panics in fee payment if balance read fails
  Changelog #3393
  Adds missing gas spending key arg to ibc tx
  Masp fee payment for shielded actions
  Fixes masp tx generation and integration tests
  Updates shielded wasm code to handle fee unshielding
  Removes unused denominate function
  Adds support for masp fee payment in sdk
  Refactors the write log api
  Different gas cost for storage deletes
  Removes write log precommit and leverages the batch log
  Adds integration tests for masp fee payment
  Refactors batch execution in case of masp fee payment
  Skips the execution of the first inner tx when masp fee payment
  Renames fee payment gas limit parameter
  Returns `BatchedTxResult` from masp fee payment
  `check_fees` drop the storage changes in case of failure
  `check_fees` checks masp fee payment
  Reworks masp fee payment to correctly handle errors. Misc refactors
  Passes the correct tx index to masp fee payment check
  Introduces masp fee payment
* origin/grarco/early-sapling-balance-check:
  Extracts the sapling value balance directly in `validate_transparent_bundle`
  Changelog #2721
  Early sapling balance check in masp vp
* origin/murisi/unconstrained-transfers:
  Generalized the Transfer event to support reporting multiple account changes.
  Unconstrain transfers and combine transfer amounts.
  Renamed some data structures.
  Added a changelog entry.
  Remove now dead code.
  Subsumed unshielding transfer into generalized transfer.
  Subsumed shielding transfer into generalized transfer.
  Subsumed shielded transfer into generalized transfer.
  Renamed TransparentTransfer to Transfer.
  Generalized the TransparentTransfer to support a shielded action.
* origin/murisi/non-malleable-masp-witness-data2:
  Added changelog entry.
  Use txids to reference MASP Transactions from Transfers and MaspBuilders.
  MASP section hash is now based on Transaction bytes.
* origin/yuji/ibc-e2e-config:
  longer interval
  add changelog
  clear on start
  change IBC e2e test config
* origin/grarco/opt-recomm:
  Changelog #3192
  Minor code optimizations
* origin/grarco/streamline-validation:
  Refactors recheck of `process_proposal` before `finalize_block`
  Changelog #3448
  Clippy + fmt
  Removes redundant check in `finalize_block` and implements recheck
  Updates docs of `finalize_block` and `process_proposal`
  Moves allowed txs check in `process_proposal` before the check on fees
  Removes duplicated validation in `prepare_proposal`
  Anticipates check on tx allowlist in mempool
* origin/fraccaman/respect-wasm-dir:
  added changelog
  respect warm-dir on init-network
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 33.85914% with 2977 lines in your changes missing coverage. Please review.

Project coverage is 53.47%. Comparing base (5cc23b4) to head (fecfaee).

Files Patch % Lines
crates/sdk/src/masp.rs 0.46% 642 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 424 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 423 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 215 Missing ⚠️
crates/shielded_token/src/validation.rs 0.00% 158 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 86 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 77.71% 78 Missing ⚠️
crates/core/src/masp.rs 2.77% 70 Missing ⚠️
crates/node/src/shell/governance.rs 3.07% 63 Missing ⚠️
crates/apps_lib/src/client/tx.rs 0.00% 61 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3486      +/-   ##
==========================================
- Coverage   53.92%   53.47%   -0.45%     
==========================================
  Files         317      320       +3     
  Lines      107575   110000    +2425     
==========================================
+ Hits        58007    58821     +814     
- Misses      49568    51179    +1611     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yito88 and others added 2 commits July 4, 2024 10:43
* origin/yuji/fix-ibc-shielding-transfer:
  remove --refund
  extract_memo_from_packet
  fix refund source
  update Hermes
  IbcShieldingData
  add changelog
  add IbcShielding action
  workaround wasm compilation error
  fix gen_masp_tx in test
  fix e2e tests
  add CLI ibc-gen-shielding
  extract masp_tx in MASP VP
  memo for masp tx
  fix the port and channel for is_receiving_success
  fix tests
  fix convert_to_address
  add ibc trace file
  reduce assumptions for IBC VP
  refactoring: add trace.rs
  fix for apply_recv_msg
  support NftTransfer
@brentstone brentstone merged commit fecfaee into main Jul 5, 2024
13 of 19 checks passed
@brentstone brentstone deleted the 0.40.0-rc branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants