Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error adding comment: The value 0 is outside of the allowed range #86

Open
RobDover opened this issue Feb 23, 2024 · 9 comments
Open

Error adding comment: The value 0 is outside of the allowed range #86

RobDover opened this issue Feb 23, 2024 · 9 comments

Comments

@RobDover
Copy link

  • Extension version: 0.2.2
  • VSCode Version: 1.86.2
  • OS: Windows_NT x64 10.0.22621

Steps to Reproduce:

  1. Installed the Azure Devops Pull Request Extension
  2. Filled in the settings required to connect me to my ADO project
  3. Opened a PR and tried to leave a comment

I see the following error message pop up:

Creating comment failed: Error: The value 0 is outside of the allowed range. Parameter name: RightFileStart.Offset
Actual value was 0.

image

I've tried a few different things to see if there are some cases where it does work and others where it doesn't, but it seems pretty consistent:

  • Have tried multiple different files in the same PR
  • Have tried a different PR
  • Have tried leaving comments on both the before and after changes
  • Have tried short and long files

Unclear exactly what's causing this, but it would be great to have this resolved! I think this extension is a great idea and would like to evangelise it across my org. Don't feel I can do that if I can't get it to work locally though :(.

@gofyndnitin
Copy link

same is happening for macOs

#87

@kwickramasekara
Copy link

+1

3 similar comments
@xhywxtt
Copy link

xhywxtt commented Mar 8, 2024

+1

@xhywxtt
Copy link

xhywxtt commented Mar 9, 2024

+1

@chrissto-hihi
Copy link

+1

@andioli
Copy link

andioli commented Mar 28, 2024

Any updates here? Do you need more info etc? #87 was closed by the author, but the problem still persists for me at least. Makes the extension unusable.

@ShyamPanchal
Copy link

+1

1 similar comment
@danbord
Copy link

danbord commented Oct 28, 2024

+1

@danbord
Copy link

danbord commented Oct 29, 2024

For anyone looking for a fix. I reviewed @danigt91 PR to fix that issue.

Since I don't really know how to code VSCode extesions, I just hacked into the installed compiled file %userprofile%\.vscode\extensions\ankitbko.vscode-pull-request-azdo-0.2.2\dist\extension.js. Searched for endOffset and startOffset in the file and set its value to 1. Saved the file, reload VSCode. Boom, now its working

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants