Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow theme based on system preferences #780

Open
mborgerson opened this issue Nov 7, 2022 · 3 comments · May be fixed by #806
Open

Allow theme based on system preferences #780

mborgerson opened this issue Nov 7, 2022 · 3 comments · May be fixed by #806
Assignees
@zwimer
Labels
enhancement

Comments

@mborgerson
Copy link
Member

Description

Many apps are themed based on system settings. It would be nice to support using the user's system-wide color scheme (dark / light) on startup.

Alternatives

No response

Additional context

No response
@mborgerson mborgerson added enhancement needs-triage Issue has yet to be looked at by a maintainer and removed needs-triage Issue has yet to be looked at by a maintainer labels Nov 7, 2022
@zwimer
Copy link
Member

zwimer commented Nov 30, 2022

Seems useful: https://github.com/albertosottile/darkdetect

@zwimer
Copy link
Member

zwimer commented Nov 30, 2022

They have a listener class as well that can be a thread target.

@zwimer zwimer self-assigned this Nov 30, 2022
@samybtt
Copy link

samybtt commented Dec 1, 2022 •
edited
Loading

Hello @zwimer, I have a small fix for this (using the "Current" option for the system theme) but I am having troubling rebuilding the project to test it. I've done it yesterday before the PySide6 refactor (#733 ), it was working with PySide2. I'm using python 3.9.5 on ubuntu 20.04.
I can make the pull request if you want to.

@zwimer zwimer linked a pull request Dec 1, 2022 that will close this issue
Open
@zwimer zwimer linked a pull request Dec 1, 2022 that will close this issue
Add system theme support #806
Open
@samybtt samybtt mentioned this issue Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zwimer zwimer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add system theme support angr/angr-management
3 participants
@mborgerson @zwimer @samybtt