This repository has been archived by the owner on Feb 12, 2021. It is now read-only.
Update Mime to fix https://nodesecurity.io/advisories/535 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterbancroft
changed the title
carterbancroft
changed the title
|
@andrewrk any indication of when this will be merged? automated nsp checks in CI are pretty common, and I'd hate to have to use a fork because of this 🚫 🍴 Thanks! |
|
@andrewrk please merge |
|
@andrewrk yeah just checking in on getting this merged... I know someone has forked it but it seems like it'd be ideal to fix this in the original repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
A RegEx denial of service attack was discovered/reported in the Mime package breaking CI builds for anyone using Node Package Security in their build process. The exploit has been fixed in Mime v1.4.1 and v2.0.3, see: https://github.com/broofa/node-mime/releases