Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling Issue >> upgrade to Scrolling Delegate required #358

Open
StefaniOSApps opened this issue Dec 6, 2018 · 2 comments
Open

Scrolling Issue >> upgrade to Scrolling Delegate required #358

StefaniOSApps opened this issue Dec 6, 2018 · 2 comments

Comments

@StefaniOSApps
Copy link

Describe the bug
If you scroll and slide your finger diagonally across the screen, the NavigationBar will not recognize it. So it will not collapse and will not expand. Furthermore, with scrolling small steps, the NavigationBar will not collapse and expand. Even if you include a UiTableview in a UiTableview and only scroll inside, the UiNavigationBar becomes unnecessarily collapsed or expand. This does not happen with a delegate method. The error is the same in all three causes.

To Reproduce
Steps to reproduce the behavior:

  1. Open Demo or your own project
  2. Slide your finger diagonally across the screen to scroll the UiTableView or UiCollectionView or...
  3. NavBar does not collapse or expand.

Expected behavior
NavBar should collapse or expand

Screenshots
If you need a video, so I can deliver it.

@andreamazz
Copy link
Owner

It's the intended behavior:
https://github.com/andreamazz/AMScrollingNavbar/blob/master/Source/ScrollingNavigationController.swift#L663-L669
I can add an option for this if needed.

@StefaniOSApps
Copy link
Author

StefaniOSApps commented Dec 6, 2018

That sounds good. There are 3 cases.

  1. Diagonal scrolling
  2. Scroll if a UiTableView has been integrated into a UiTableViewCell
  3. Scrolling is not recognized when the scrolling steps are very small.

one more issue

  1. Drag and Drop UiTableViewCells (The NavBar did collapse or expand by dragging (not scrolling))

#358 (comment)
This solves the first point. There are still 2 left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants