build: provide snapcraft yaml for cross distribution packaging #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a snapcraft yaml and merge it into tuo Makefile to provide an easy way to publish for generic Linux packaging. Integrated into usual make via target "make snap". See http://snapcraft.io/ for more detail on snaps. Signed-off-by: Christian Ehrhardt <[email protected]>
Signed-off-by: Christian Ehrhardt <[email protected]>
As reported before the obj is not created and thereby can let the build fail. (Fixes andor9#15) Signed-off-by: Christian Ehrhardt <[email protected]>
making the makefile more common in providing a valid install/uninstall rule. The rules allow to set DESTDIR if needed and to overwrite the default PREFIX of /usr/local. Signed-off-by: Christian Ehrhardt <[email protected]>
I realized that fixing up the TUO build in the snap plugin was kind of an exercise for me back then. But there is no reason to do so. Now that the build issues are fixed I can simplify the snapcraft.yaml to use the default make plugin. Signed-off-by: Christian Ehrhardt <[email protected]>
|
Updated with a few fixes to the Makefile, which btw fixes issue #15 and eventually allows me to further simplify the snap build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andor9,
I worked a bit on snaps recently and since I personally used TUO a lot to manage my deck I considered it a great yet simple example to start with:
=> https://github.com/ubuntu/snappy-playpen/tree/master/tyrant-unleashed-optimizer
Now I used it packaged this way a bit for myself and I'm happy, so I thought it might be just right to feed back that packaging. I saw that there were no recent updates to the repo, yet I thought it is worth to at least provide it for your consideration.
Please let me know if you want me to help with build&publishing (might be easier for me as I have all the setup of snapcraft and lxd ready). Getting it into the snap store would make TUO instantly available across various Linux Distributions which would be great for at least me and quite a few Linux&TUO friends I have.
See http://snapcraft.io/ for more detail on snaps and snapcraft.