fix: Consider all amounts in multi-currency postings #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a transaction like:
```ledger
2024/01/01 Cash transfer
Assets:Savings
Assets:Checking -20,000 INR
Assets:Checking -500 USD
```
The posting returned by `hledger` will have a list of two amounts in
the JSON key `pamount`, for the `Assets:Savings` account. Currently, we
are only consider the first one we find, so the one for USD is ignored.
This change iterates over all the received amounts for each posting, to
avoid incorrect calculations when this type of transactions are present.
|
I do not plan to accept any pull request for now. If you |
adamantike
deleted the
fix/consider-all-amounts-in-multi-currency-posting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a transaction like:
The posting returned by
hledgerwill have a list of two amounts in the JSON keypamount, for theAssets:Savingsaccount. Currently, we are only considering the first one we find, so the one for USD is ignored.This change iterates over all the received amounts for each posting, to avoid incorrect calculations when this type of transactions are present.