Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Glog v0.3.5 to something newer #802

Open
dNechita opened this issue Sep 28, 2022 · 0 comments
Open

Move from Glog v0.3.5 to something newer #802

dNechita opened this issue Sep 28, 2022 · 0 comments
Labels
bug Something isn't working CI dependencies Pull requests that update a dependency file

Comments

@dNechita
Copy link
Collaborator

Glog v3.5.0 no longer builds on Ubuntu 22.04. It fails to build some unittests. There is no cmake option to deactivate them. So we have to move to a newer version of glog.

Compilation error message was:


In file included from /home/dan/repos/glog/src/logging_unittest.cc:58:

/home/dan/repos/glog/src/googletest.h:579:33: error: ISO C++17 does not allow dynamic exception specifications

  579 | void* operator new(size_t size) throw(std::bad_alloc) {

      |                                 ^~~~~

/home/dan/repos/glog/src/googletest.h:586:35: error: ISO C++17 does not allow dynamic exception specifications

  586 | void* operator new[](size_t size) throw(std::bad_alloc) {
@dNechita dNechita added bug Something isn't working CI dependencies Pull requests that update a dependency file labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant