Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow system package installation for conan by default #287

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

FeignClaims
Copy link
Contributor

This makes conan in cmake more transparent.

@aminya
Copy link
Owner

aminya commented Nov 10, 2024

Does this work with Conan 1 as well as 2?

@FeignClaims
Copy link
Contributor Author

Does this work with Conan 1 as well as 2?

Only conan 2. Currently cmake-conan integration for Conan 1.X is no longer mantainedand and Conan Center has stopped receiving updates for Conan 1.x packages, so I didn't consider how to enable it for conan 1.

src/Conan.cmake Show resolved Hide resolved
@aminya
Copy link
Owner

aminya commented Nov 10, 2024

@FeignClaims
Copy link
Contributor Author

@aminya
Copy link
Owner

aminya commented Nov 10, 2024

Thank you!

@aminya aminya merged commit bee4308 into aminya:main Nov 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants