Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRQ: general distribution evaluate-class #57

Closed
7 tasks done
kay-ro opened this issue Oct 9, 2024 · 0 comments · Fixed by #70
Closed
7 tasks done

FRQ: general distribution evaluate-class #57

kay-ro opened this issue Oct 9, 2024 · 0 comments · Fixed by #70
Assignees
Labels
module: evaluate new feature New feature release: minor Issues that need to be addressed in a minor release status: ready for review Needs to be reviewed

Comments

@kay-ro
Copy link
Member

kay-ro commented Oct 9, 2024

Proposed new feature or change:

Additionally to evaluate.VelDist, LDDist and others, sometimes it is necessary to get the distribution function of different observables. One example is angular momentum which might be compared to a Maxwell-Boltzmann distribution. Others might be orientation distribution,...

  • write general class evaluate.Dist
  • allow for extra averaging functions (i.e. np.linalg.norm(...)/...)
  • allow for logbins
  • name in distobject.save(..., name="...")
  • write examples in docstring also for saving!
  • default name of class only "dist"
  • write test
@kay-ro kay-ro added new feature New feature release: minor Issues that need to be addressed in a minor release status: in progress Someone is working on this issue module: evaluate labels Oct 9, 2024
@kay-ro kay-ro self-assigned this Oct 9, 2024
@kay-ro kay-ro added status: ready for review Needs to be reviewed and removed status: in progress Someone is working on this issue labels Oct 21, 2024
@kay-ro kay-ro linked a pull request Oct 21, 2024 that will close this issue
@kay-ro kay-ro added this to the release v1.1.0 milestone Oct 22, 2024
@kay-ro kay-ro closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: evaluate new feature New feature release: minor Issues that need to be addressed in a minor release status: ready for review Needs to be reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant