You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
The documentation at https://github.com/awslabs/k8s-cloudwatch-adapter/blob/v0.10.0/docs/cross-account.md suggests that the service role needs to be able to pass the target role for cross-account metrics. However, it appears that the service role need only assume the target role.
If
roleArn
is present in the ExternalMetric spec the client gets credentials that assume the role by callingstscreds.NewCredentials
: https://github.com/awslabs/k8s-cloudwatch-adapter/blob/2dd7711adeb15b37f59cd1a05967796bdd6cdff3/pkg/aws/client.go#L41. That function uses anAssumeRoleProvider
: https://github.com/aws/aws-sdk-go/blob/de0aa785c5d4efb004061153d592f8e1641f91c4/aws/credentials/stscreds/assume_role_provider.go#L257With v0.10.0 I've managed to scale a deployment based on metrics in a separate account with a service role policy like,
And a target role policy with,
Should the documentation be updated to omit the "iam:PassRole" statement?
The text was updated successfully, but these errors were encountered: