Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open ngx_http_upstream_rbtree_lookup as api #1868

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

lhanjian
Copy link
Collaborator

Sometimes, we need to optimize RBTREE in the area of other files. At this time, this function needs to be exposed.

有时候,我们需要在其他文件的区域内,进行RBTREE的优化,此时,这个函数需要暴露出去

eg:lhanjian/lua-upstream-nginx-module@70f7311

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2023

CLA assistant check
All committers have signed the CLA.

@lhanjian
Copy link
Collaborator Author

@SarahWang Thanks for implementaing RBTREE of tengine

Copy link
Member

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi could you double check this PR @drawing

@drawing
Copy link
Collaborator

drawing commented Oct 31, 2023

hi could you double check this PR @drawing

@chobits ngx_http_upstream_rbtree_lookup is a tengine extension function, isolated by the macro NGX_HTTP_UPSTREAM_RBTREE. This PR changes the function from static to global. I think there is no problem with this modification.

@chobits chobits merged commit 2d609f5 into alibaba:master Oct 31, 2023
8 checks passed
jizhuozhi pushed a commit to jizhuozhi/tengine that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants