Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] how to distinguish the metric with passed record #501

Open
qshuai opened this issue Jan 16, 2023 · 0 comments
Open

[BUG] how to distinguish the metric with passed record #501

qshuai opened this issue Jan 16, 2023 · 0 comments
Labels
area/metrics Issue related to metrics and monitoring

Comments

@qshuai
Copy link

qshuai commented Jan 16, 2023

prometheus metric example:

sentinel_go_handled_total{app="unknown_go_service",block_type="",host="xxx",pid="1",resource="GET:/api/test/error",result="pass"} 1213
sentinel_go_handled_total{app="unknown_go_service",block_type="",host="xxx",pid="1",resource="GET:/test/panic",result="pass"} 193

the first record is circuitbreak metric. the other is flow control metric.
But there is not a label to distinguish which the entry belongs to.
qshuai added a commit to qshuai/sentinel-golang that referenced this issue Jan 16, 2023
@qshuai
fix: add traffic-type label to distinguish pass type, fix alibaba#501
8dbc6d7
qshuai added a commit to qshuai/sentinel-golang that referenced this issue Jan 16, 2023
@qshuai
fix: add traffic-type label to distiguish pass type, fix alibaba#501
437898f
@sczyh30 sczyh30 added the area/metrics Issue related to metrics and monitoring label Jan 17, 2023
@qshuai qshuai mentioned this issue Jan 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/metrics Issue related to metrics and monitoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sczyh30 @qshuai