Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复watch 构造方法的问题 #2939

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

修复watch 构造方法的问题 #2939

wants to merge 2 commits into from

Conversation

Allan-QLB
Copy link
Contributor

fix #2933

@hengyunabc
Copy link
Collaborator

😂，这个只是一个特制的补丁。要是用户在 watch 的条件表达式里，要显式输入 <xxx> , <yyy> 之类的呢？

原来的 token 解析没有考虑到字符串，要根本解决这个问题，估计要完全重写 token 解析。

@Allan-QLB
Copy link
Contributor Author

😂，这个只是一个特制的补丁。要是用户在 watch 的条件表达式里，要显式输入 <xxx> , <yyy> 之类的呢？

原来的 token 解析没有考虑到字符串，要根本解决这个问题，估计要完全重写 token 解析。

我看了命令行和token解析的代码，有很多问题，一些特定的场景下很多命令识别、补全 都会有问题，要解决这些问题，命令行解析这块得重新设计实现

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.0.0 及之后版本不支持 watch 构造函数
2 participants
@Allan-QLB @hengyunabc