Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 及之后版本不支持 watch 构造函数 #2933

Open
hengyunabc opened this issue Nov 4, 2024 · 1 comment · May be fixed by #2939
Open

4.0.0 及之后版本不支持 watch 构造函数 #2933

hengyunabc opened this issue Nov 4, 2024 · 1 comment · May be fixed by #2939
Labels
bug Something isn't working

Comments

@hengyunabc
Copy link
Collaborator

#2658 引入的Bug。 @Allan-QLB

下面这两个命令都会识别为重定向:

watch demo.MathGame '<init>'
watch demo.MathGame <init>
    @Test
    public void testSeparateRedirect2() {
        String[] expectedTextTokenValue = new String[]{"watch", "demo.MathGame", "<init>"};
        String cmd = "watch demo.MathGame '<init>'";
        List<CliToken> actualTokens = CliTokenImpl.tokenize(cmd);
        assertEqualsIgnoreBlank(expectedTextTokenValue, actualTokens);
        Assert.assertEquals(cmd, concatRaw(actualTokens));
    }
@hengyunabc hengyunabc added the bug Something isn't working label Nov 4, 2024
Allan-QLB added a commit to Allan-QLB/arthas that referenced this issue Nov 8, 2024
@Allan-QLB Allan-QLB linked a pull request Nov 8, 2024 that will close this issue
@hengyunabc
Copy link
Collaborator Author

目前没有太好的修复办法,需要整体重构 token 的解析。考虑先把 #2658 revert 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant