Error installing with Numpy 2.0

[alejandrobll]

As Numpy 2.0 has broken some parts of the code, use Numpy 1.26.4 until we make the required changes to adhere to the new C-API:

pip install numpy==1.26.4

Sorry for the inconvenience.

[VictorForouhar]

I found an error that I think is related to what you mention here. I encountered it because I was setting up after the COSMA update.

My steps to reproduce (modules = 1)cosma/2018 2) python/3.12.4(default) 3) utils/201805(default):

python3 -m venv bug_test
source bug_test/bin/activate
pip install numpy setuptools
git clone https://github.com/alejandrobll/py-sphviewer.git
python setup.py install

This throws two errors, e.g:

sphviewer/extensions/scenemodule.c:79:69: error: ‘PyArray_FLOAT’ undeclared (first use in this function); did you mean ‘PyArray_ISFLOAT’?
PyArrayObject *cont_obj = PyArray_ContiguousFromObject(array_obj, PyArray_FLOAT, 1, 3);

Based on this solution, I changed PyArray_FLOAT and PyArray_DOUBLE to NPY_FLOAT and NPY_DOUBLE. Doing so installs it successfully with numpy 2.0.0.

I created a merge request here: #37

[VictorForouhar]

I suspect that setup.py will also need updating. This is because, despite being able to install it, pip throws some warnings (and apparently duplicates pip list entries) after installing. The alternative of installing using pip install py-sphviewer was not working, as it was not detecting my installation of numpy (I suspect it was not looking for it in my venv).

[alejandrobll]

Many thanks, Victor. It is weird that this works. PyArray_NAME should be independent of Numpy, I assume, so I do not understand why this is related to the update, but honestly, I haven't followed the changes introduced in the last update. If this works for now, let's use your solution. I need to find time to sit down and check what's really going on. Cheers, Alejandro.

…

On Mon, 15 Jul 2024 at 13:49, Victor J. Forouhar Moreno < ***@***.***> wrote: I suspect that setup.py will also need updating. This is because, despite being able to install it, pip throws some warnings (and apparently duplicates pip list entries) after installing. The alternative of installing using pip install py-sphviewer was not working, as it was not detecting my installation of numpy (I suspect it was not looking for it in my venv). — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYAMDJHIZZDLET5GQZGJALZMOZMTAVCNFSM6AAAAABKMWKQMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGMYTGOBQGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Alejandro Benítez Llambay

[VictorForouhar]

Hi Alejandro,

I agree that the naming is confusing. I went digging a little bit deeper, and PyArray seems to be numpy specific. Based on that, it is not that unsurprising that they now prefer using NPY_ (and it is less confusing!)

In terms of why the old name stopped working. This header contained name equivalences between PyArray_DTYPE and NPY_DTYPE. The file is no longer present in numpy 2.0.

Thanks,
Victor.

[alejandrobll]

Ah, I see. Indeed, confusing. Many thanks for looking into it :). Cheers, Ale.

…

On Tue, 16 Jul 2024 at 10:08, Victor J. Forouhar Moreno < ***@***.***> wrote: Hi Alejandro, I agree that the naming is confusing. I went digging a little bit deeper, and PyArray seems to be numpy specific. Based on that, it is not that unsurprising that they now prefer using NPY_ (and it is less confusing!) In terms of why the old name stopped working. This header <https://github.com/numpy/numpy/blob/maintenance/1.26.x/numpy/core/include/numpy/old_defines.h> contained name equivalences between PyArray_DTYPE and NPY_DTYPE. The file is no longer present in numpy 2.0. Thanks, Victor. — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYAMDN2D6QHWX47LR3P62DZMTIJXAVCNFSM6AAAAABKMWKQMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGI4DENZRGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Alejandro Benítez Llambay