Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image Toggle #47

Closed
jenieg opened this issue Sep 30, 2024 · 2 comments · Fixed by #55
Closed

Add Image Toggle #47

jenieg opened this issue Sep 30, 2024 · 2 comments · Fixed by #55
Labels
good first issue Good for newcomers react

Comments

@jenieg
Copy link

jenieg commented Sep 30, 2024

Add the ability to toggle the profile image to be included or not.
@alcpereira alcpereira added good first issue Good for newcomers react labels Oct 1, 2024
@alcpereira
Copy link
Owner

Depending on when #39 lands, we can either add this option in the data.json or in the future configuration file.

Basically the steps would be:

  • Add a key shouldDisplayProfileImage (or another name) with a default value of false in the profile section of the config
  • Add conditional rendering in the ProfileHeader component the ProfileImage part
  • Adjust potential layout issues if any

@flufynarwhal
Copy link
Contributor

interested in working on this

@MoisesGJ MoisesGJ mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle profile image display logic MoisesGJ/cv-generator
3 participants
@alcpereira @jenieg @flufynarwhal