Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version to 0.0.19 #41

Merged
merged 5 commits into from
Oct 23, 2024
Merged

version to 0.0.19 #41

merged 5 commits into from
Oct 23, 2024

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Oct 23, 2024

Summary by Sourcery

Build:

  • Update pre-commit configuration to use mypy version 1.13.0.

Copy link
Contributor

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the version of the mypy pre-commit hook from v1.12.1 to v1.13.0 in the .pre-commit-config.yaml file. This is a minor version update for the static type checker tool.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update mypy pre-commit hook version
  • Changed mypy version from v1.12.1 to v1.13.0
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1279734). Learn more about missing BASE report.

Files with missing lines Patch % Lines
albucore/utils.py 0.00% 6 Missing ⚠️
benchmark/albucore_benchmark/benchmark.py 0.00% 5 Missing ⚠️
albucore/__init__.py 60.00% 4 Missing ⚠️
setup.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   59.85%           
=======================================
  Files           ?       19           
  Lines           ?     2120           
  Branches        ?        0           
=======================================
  Hits            ?     1269           
  Misses          ?      851           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 5417ae6 into main Oct 23, 2024
16 checks passed
@ternaus ternaus deleted the boost_version branch October 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants