-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added decorator to show way to process data #31
Conversation
Reviewer's Guide by SourceryThis pull request introduces two new decorators for image processing functions: File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 5 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage ? 59.23%
=======================================
Files ? 17
Lines ? 1906
Branches ? 0
=======================================
Hits ? 1129
Misses ? 777
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Add decorators to ensure consistent data types for image processing functions and optimize data type handling in conversion functions. Update tests to cover new decorators and improve pre-commit configuration.
New Features:
float32_io
anduint8_io
decorators to ensure consistent input/output data types for image processing functions, converting images to float32 or uint8 as needed.Enhancements:
to_float
andfrom_float
functions to handle float32 and float64 data types more efficiently by avoiding unnecessary conversions.Build:
Tests:
float32_io
anduint8_io
decorators to verify that they correctly handle data type conversions and preserve the original data type.to_float
returns the same object for float32 inputs and thatto_float
andfrom_float
functions maintain data integrity through round-trip conversions.Chores:
contiguous
andpreserve_channel_dim
decorators to a newdecorators.py
file for better organization.