Failed the validation check for streaming features if accuracy is specified as snapshot #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengyu-hou
approved these changes
Nov 18, 2024
api/py/test/test_group_by.py
Outdated
| @@ -174,7 +175,23 @@ def test_validator_ok(): | |||
| aggregations=None, | |||
| ) | |||
|
|
|||
|
|
|||
| def test_validator_accuracy(): | |||
| with pytest.raises(AssertionError): | |||
There was a problem hiding this comment.
can we check the assertion error message?
| accuracy=Accuracy.SNAPSHOT, | ||
| ) | ||
| assert all([agg.inputColumn for agg in gb.aggregations if agg.operation != ttypes.Operation.COUNT]) | ||
| group_by.validate_group_by(gb) |
There was a problem hiding this comment.
nit: add some new lines in between methods.
pallavia7
force-pushed
the
pallavi--accuracy-compiler
branch
from
033f438
to
1f4f821
Compare
hzding621
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For streaming features, failing the validation check if accuracy is specified as snapshot
Why / Goal
Test Plan
Checklist
Reviewers