Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests + exception for MPI runs #62

Open
ltalirz opened this issue Nov 21, 2022 · 2 comments
Open

add tests + exception for MPI runs #62

ltalirz opened this issue Nov 21, 2022 · 2 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Nov 21, 2022

Will merge #47 since it is needed by aiida-lsmo, but one should add

  • a test of a run withmpi=True
  • if possible, an exception/warning, if a number of processes >1 is detected (or implement a solution for it)
@greschd
Copy link
Member

greschd commented Nov 21, 2022

or implement a solution for it

Maybe this can be done with mpi4py? Something like:

  • process 1 checks for a cache hit, all other processes wait
  • if cache hit, use cache and terminate
  • if no cache hit, each process launches its "real executable"?

Not sure if this would work, but might be worth doing a PoC for.

@ltalirz
Copy link
Member Author

ltalirz commented Nov 21, 2022

Thanks for the suggestion @greschd, yes I guess that could work!

In my view, it does look a bit convoluted though, and perhaps it is better to go the monkeypatching route #49.
Besides making the handling of MPI codes straightforward, it also has the key benefit of improving debugging info when the call to the mock executable does not go as expected (which, in my experience, is the main pain point in using mock_code at the moment, and hinders its wider adoption).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants