Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update math_differential_calculus.ipynb #408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update math_differential_calculus.ipynb #408

wants to merge 1 commit into from

Conversation

zuhairabid
Copy link

Just to make the eqn. more clear in the graph

@zuhairabid
Update math_differential_calculus.ipynb
a21e3cd 
Just to make the eqn. more clear in the graph
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ageron
Copy link
Owner

ageron commented Mar 18, 2021

Hi @zuhairabid ,
Thanks for your PR! The animate_tangent() function is used in another place with another function, so we can't hard-code y=f'(x)=2x in the function itself. However, I like the idea, so perhaps we could instead have an extra argument fp_str for this function, with default value None, and if it's not None then we use the title "y=f'(x)=" + fp_str.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuhairabid @ageron