Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from-state actions on EOF are executed only if there are EOF transition actions #80

Open
adrian-thurston opened this issue Dec 28, 2021 · 0 comments

Comments

@adrian-thurston
Copy link
Owner

adrian-thurston commented Dec 28, 2021

When there are from-state actions that should be executed on EOF we are currently not falling through to execute them. We need to check for from-state actions and generate the fall through.

adrian-thurston added a commit that referenced this issue Dec 28, 2021
refs #80 from-state actions on EOF are executed only if there are EOF
transition actions
adrian-thurston added a commit to adrian-thurston/colm that referenced this issue Dec 28, 2021
From-state actions now execute on EOF, but we don't check for their presence
when deciding if we should test against EOF. This led to from-state actions
executing only if other conditions necessitating EOF-testing are present. Added
the check.

refs adrian-thurston/ragel#80
adrian-thurston added a commit that referenced this issue Dec 28, 2021
With the fix in for #80, test cases that embed from-state actions, but no eof
actions, now need to have eof set. Updating output to reflect the calls on eof
is also required in some cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant