From 4a99ede1f0944c4a8e3e0bb5d855e867d7aa8fea Mon Sep 17 00:00:00 2001 From: Carlos Sousa Date: Sat, 4 May 2024 00:20:39 -0300 Subject: [PATCH 1/7] add workflow file to run arm-based testing with sanitizers --- .github/workflows/aarch64.yml | 47 +++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 .github/workflows/aarch64.yml diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml new file mode 100644 index 000000000..dc126e754 --- /dev/null +++ b/.github/workflows/aarch64.yml @@ -0,0 +1,47 @@ +name: Ubuntu aarch64 (GCC 11) + +on: + pull_request: + types: [opened, synchronize, reopened, ready_for_review] + paths-ignore: + - '**.md' + - 'docs/**' + push: + branches: + - main + paths-ignore: + - '**.md' + - 'docs/**' + +permissions: + contents: read + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +jobs: + build: + runs-on: ubuntu-latest + strategy: + matrix: + shared: [ON, OFF] + steps: + - uses: actions/checkout@v4 + - uses: uraimo/run-on-arch-action@v2 + name: Build + id: runcmd + with: + arch: aarch64 + githubToken: ${{ github.token }} + distro: ubuntu_latest + install: | + apt-get update -q -y + apt-get install -y cmake make g++ ninja-build + run: | + cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build + cmake --build build -j=2 + env: + CXX: g++-12 + - name: Test + run: ctest --output-on-failure --test-dir build From 70e654509d89d496ffc838a3459006f1b4075e31 Mon Sep 17 00:00:00 2001 From: Carlos Sousa Date: Sat, 4 May 2024 00:50:59 -0300 Subject: [PATCH 2/7] fix env parameter, move to parent --- .github/workflows/aarch64.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml index dc126e754..1322a199a 100644 --- a/.github/workflows/aarch64.yml +++ b/.github/workflows/aarch64.yml @@ -31,6 +31,8 @@ jobs: - uses: uraimo/run-on-arch-action@v2 name: Build id: runcmd + env: + CXX: g++-12 with: arch: aarch64 githubToken: ${{ github.token }} @@ -41,7 +43,5 @@ jobs: run: | cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build cmake --build build -j=2 - env: - CXX: g++-12 - name: Test run: ctest --output-on-failure --test-dir build From 4052093cbf4291102c70a1b8b3c5464c00a7d7bb Mon Sep 17 00:00:00 2001 From: Carlos Sousa Date: Wed, 8 May 2024 11:30:58 -0300 Subject: [PATCH 3/7] update image used to checkout --- .github/workflows/aarch64.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml index 1322a199a..f9e8b0a09 100644 --- a/.github/workflows/aarch64.yml +++ b/.github/workflows/aarch64.yml @@ -27,7 +27,7 @@ jobs: matrix: shared: [ON, OFF] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 - uses: uraimo/run-on-arch-action@v2 name: Build id: runcmd From bad315282c4967048a5d728ba2405276dd1b0c2f Mon Sep 17 00:00:00 2001 From: Carlos Sousa Date: Thu, 9 May 2024 19:28:44 -0300 Subject: [PATCH 4/7] Remove permissions declaration for testing purposes --- .github/workflows/aarch64.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml index f9e8b0a09..6a6ff0581 100644 --- a/.github/workflows/aarch64.yml +++ b/.github/workflows/aarch64.yml @@ -13,9 +13,6 @@ on: - '**.md' - 'docs/**' -permissions: - contents: read - concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true From f909d677fa1da9a83dbb9096da569f2bd9e5f088 Mon Sep 17 00:00:00 2001 From: Carlos Sousa Date: Thu, 9 May 2024 19:57:58 -0300 Subject: [PATCH 5/7] Remove --output-on-failure for testing purposes --- .github/workflows/aarch64.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml index 6a6ff0581..5ca3291b2 100644 --- a/.github/workflows/aarch64.yml +++ b/.github/workflows/aarch64.yml @@ -41,4 +41,4 @@ jobs: cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build cmake --build build -j=2 - name: Test - run: ctest --output-on-failure --test-dir build + run: ctest --test-dir build From 1716753c149b7604efc92d027ea18467e8f2db1f Mon Sep 17 00:00:00 2001 From: Carlos Sousa Date: Thu, 9 May 2024 21:40:16 -0300 Subject: [PATCH 6/7] Move test command to same step of build --- .github/workflows/aarch64.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml index 5ca3291b2..9ce353101 100644 --- a/.github/workflows/aarch64.yml +++ b/.github/workflows/aarch64.yml @@ -26,7 +26,7 @@ jobs: steps: - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 - uses: uraimo/run-on-arch-action@v2 - name: Build + name: Build and Test id: runcmd env: CXX: g++-12 @@ -40,5 +40,4 @@ jobs: run: | cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build cmake --build build -j=2 - - name: Test - run: ctest --test-dir build + ctest --test-dir build From c6c94e32758953c9b579ed509f2bcc12da89152a Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Fri, 10 May 2024 06:35:10 -0400 Subject: [PATCH 7/7] Update aarch64.yml --- .github/workflows/aarch64.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aarch64.yml b/.github/workflows/aarch64.yml index 9ce353101..81431bec1 100644 --- a/.github/workflows/aarch64.yml +++ b/.github/workflows/aarch64.yml @@ -1,4 +1,4 @@ -name: Ubuntu aarch64 (GCC 11) +name: Ubuntu aarch64 (GCC 12) on: pull_request: