Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL when hijacking links for client-side only operations #33

Open
dhedlund opened this issue Aug 2, 2013 · 0 comments
Open

Change URL when hijacking links for client-side only operations #33

dhedlund opened this issue Aug 2, 2013 · 0 comments

Comments

@dhedlund
Copy link
Contributor

dhedlund commented Aug 2, 2013

Some links on the website trigger javascript actions. Many of these anchor tags have a fallback URL in case the user has javascript disabled. When an action is performed client-side, it should also update the browser URL with the URL for the server-side action that would've happened had javascript been disabled.

Since we only support relatively modern browsers, this can be done using HTML5 window.history.pushState and/or window.history.replaceState, whichever makes the most sense based on experimentation.

Known anchor tags that are hijacked:

  • Event index view switching (/events?view=calendar)
  • Map index view switching (/venues?view=map)
  • Map index "show all venues" (/venues?all=1)
dhedlund pushed a commit that referenced this issue Nov 20, 2013
Baked a new release v0.20130717:
  * [DEPENDENCY] Upgraded to rails 3.2.13.
  * Fixed #30: Relax markdown emphasis parsing to avoid adding emphasis to words_containing_underscores.
  * Fixed #22 and #33: avoid double-output of cache block for filtered events.
  * Fixed #35: Use 'medium' git log format for footer version number.
  * Fixed #36, #37: Limit the number of links in event descriptions to three.
  * Fixed Google Code issue #280: Strip whitespace from venue fields.
  * Fixed #38: Fixed display of events with no end time
  * Added Schema.org support to event markup.
  * Updated spam blacklist.

Also, manufactured tags and wrote release notes for past stable releases
that were never officially tagged or released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant