Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in enum keys generation: underscores should not be removed if enum value contains digits. E. g. for value AMAZON_S3 generated key AMAZONS3 is wrong #988

Open
nicky1038 opened this issue Nov 20, 2024 · 0 comments

Comments

@nicky1038
Copy link

nicky1038 commented Nov 20, 2024

For example, this enum definition

[
    //...
    "foo.bar.StorageType": {
      "description": "this enum contains available object storages",
      "type": "string",
      "default": "ORACLE_OBJECT_STORAGE",
      "enum": [
        "ORACLE_OBJECT_STORAGE",
        "AMAZON_S3",
      ]
    },
    //...
]

is transformed into

export enum FooBarStorageTypeDto {
  ORACLE_OBJECT_STORAGE = "ORACLE_OBJECT_STORAGE",
  AMAZONS3 = "AMAZON_S3",
}

Please notice AMAZONS3. The key should be AMAZON_S3, but the underscore is being removed.

It happens because of this regexp, AMAZON_S3 doesn't match it. I guess the regexp should be changed in order to support names with digits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant