MG-2048 - Implement Personal Access Tokens (PATs) #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dborovcanin
changed the title
nyagamunene
force-pushed
the
MG-2048
branch
5 times, most recently
from
c057ea7
to
3ad5253
Compare
nyagamunene
force-pushed
the
MG-2048
branch
3 times, most recently
from
2b465a8
to
7eee43e
Compare
arvindh123
requested changes
Nov 12, 2024
| @@ -109,3 +109,4 @@ func encodeAuthorizeRequest(_ context.Context, grpcReq interface{}) (interface{} | |||
| Object: req.Object, | |||
| }, nil | |||
| } | |||
|
|
|||
auth/api/grpc/auth/requests.go
Outdated
Comment on lines
52
to
67
|
|
||
| type authPATReq struct { | ||
| paToken string | ||
| platformEntityType string | ||
| optionalDomainID string | ||
| optionalDomainEntityType string | ||
| operation string | ||
| entityIDs []string | ||
| } | ||
|
|
||
| func (req authPATReq) validate() error { | ||
| if req.paToken == "" { | ||
| return apiutil.ErrBearerToken | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This was not used anywhere
pkg/authn/authsvc/authn.go
Outdated
| @@ -42,5 +42,5 @@ func (a authentication) Authenticate(ctx context.Context, token string) (authn.S | |||
| if err != nil { | |||
| return authn.Session{}, errors.Wrap(errors.ErrAuthentication, err) | |||
| } | |||
| return authn.Session{DomainUserID: res.GetId(), UserID: res.GetUserId(), DomainID: res.GetDomainId()}, nil | |||
| return authn.Session{ID: res.GetId(), UserID: res.GetUserId(), DomainID: res.GetDomainId()}, nil | |||
There was a problem hiding this comment.
Please revert to DomainUserID,This affect everywhere, since we are using DomainUserID in all places
There was a problem hiding this comment.
Since domain was removed from token this will be empty
arvindh123
force-pushed
the
auth-refactor
branch
2 times, most recently
from
3f43476
to
4323d34
Compare
dborovcanin
force-pushed
the
auth-refactor
branch
from
4323d34
to
c04c035
Compare
dborovcanin
force-pushed
the
auth-refactor
branch
from
c04c035
to
37e5c2c
Compare
dborovcanin
force-pushed
the
auth-refactor
branch
2 times, most recently
from
33a88f8
to
c1faa58
Compare
dborovcanin
changed the title
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
… user, clients, channels (absmach#2506) Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]> Signed-off-by: Felix Gateru <[email protected]> Co-authored-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]> Co-authored-by: Arvindh <[email protected]>
dborovcanin
force-pushed
the
auth-refactor
branch
from
dfb07d3
to
4abbbdf
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin
force-pushed
the
auth-refactor
branch
from
4abbbdf
to
bdd542d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: It add personal access token.
What does this do?
It adds personal access token.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes
Did you document any new/modified feature?
No
Notes