Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure there is no attempt to re-attach DETACHING channel after connection becomes SUSPENDED #242

Open
3 tasks
lawrence-forooghian opened this issue Nov 25, 2024 · 1 comment

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 25, 2024

See internal conversation.

We think the spec does not define what should happen when the following sequence of events occurs:

  1. the user calls detach(), putting the channel into DETACHING;
  2. some time after, the connection becomes SUSPENDED;
  3. some time after, the connection becomes CONNECTED again.

In particular, does the channel reattach and start receiving messages again? The desired behaviour is that it not do so. The way in which to make this happen is probably to make sure that the channel ends up in the DETACHED state when the connection becomes SUSPENDED.

The aims of this task are to:

  • make sure that this behaviour is specified
  • once specified, create SDK repo issues to implement this
  • in particular, implement in JS as a priority
@sacOO7
Copy link
Collaborator

sacOO7 commented Nov 27, 2024

Yeah, I agree, if connection goes suspended and existing channel state is detaching, then it should go detached. This also goes as per https://sdk.ably.com/builds/ably/specification/main/features/#RTL5j
Mainly, Connection state change side effects spec needs a revision based on the given channel state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants