deviceSecret must be part of DeviceDetails for protocol 2.0 - or rethought

[ikbalkaya]

Some context and discussion : ably/ably-java#842 (comment)

Ably protocol requires deviceSecret on push registrations but currently IDL defines deviceSecret as part of LocalDevice which is defined as a subclass of DeviceDetails.

@paddybyers made a comment here ably/ably-java#845 (comment)
explaining that the original intention was right and custom registrar requirement created this design flaw.

As a result,I think either the deviceSecret must be moved to DeviceDetails or the process must be rethought and spec updated.

[sync-by-unito]

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2903

[lawrence-forooghian]

Ably protocol requires deviceSecret on push registrations

This was true of the REST push device registration API when protocol version 2 was first introduced, but is no longer the case; see this internal Slack thread.

What Paddy said about custom registrars needing a way to receive the device identity credentials remains unsolved, but it does not need to be solved as part of implementing protocol v2 in the SDKs.

[sacOO7]

This is fixed serverside as a part of https://github.com/ably/realtime/pull/5394. It was part of the slack discussion https://ably-real-time.slack.com/archives/C030C5YLY/p1700741804479899?thread_ts=1699279152.506959&cid=C030C5YLY