Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptographyDeprecationWarning for TripleDES in yubikit/piv.py #636

Open
elonen opened this issue Sep 13, 2024 · 2 comments
Open

CryptographyDeprecationWarning for TripleDES in yubikit/piv.py #636

elonen opened this issue Sep 13, 2024 · 2 comments

Comments

@elonen
Copy link

elonen commented Sep 13, 2024

  • YubiKey Manager (ykman) version: 5.5.1
  • How was it installed?: pip
  • Operating system and version: MacOS
  • YubiKey model and version: 5
  • Bug description summary:

Calling authenticate with a TDES management key in yubikit/piv.py causes cryptography library to print a deprecation warning to the console:
CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0

Steps to reproduce

ses PivSession = ...
ses.authenticate(MANAGEMENT_KEY_TYPE.TDES, yubikit.piv.DEFAULT_MANAGEMENT_KEY)

Expected result

No warnings.

Actual results and logs

yubikit/piv.py:160: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  return algorithms.TripleDES(management_key)

Other info

cryptography==43.0.1

dainnilsson added a commit that referenced this issue Oct 1, 2024
@dainnilsson
Copy link
Member

Thanks! This has been addressed on main and will be included in the next release.

@Kuko0419
Copy link

Kuko0419 commented Oct 8, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants