-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thinking about React 15 support #58
Comments
hey @tbranyen any update on this? |
This is a much nicer interface |
The focus can also be on React 16 now. |
this would be nice. A provider component is the way to go! |
The way I see it is the difference is that you explicitly require elements' dependencies. While I see the point, I find it a bit weird. You don't do: import {div, br, table} from 'react-dom'; for instance, to load the driver's primitives. The distinction enables you to separate primitives from components, no? |
If it's easy to make that work, then I agree with that feedback. I'm actually really needing this now for a project at work so I can put some time into make it work the way I proposed. If you have some tips on how to preload React with those components so it works like react-dom does, then I'd be happy to do it that way. |
I don't understand what you mean. This is already the case. Tou don't have to "preload" the components, they are not components but primitives. |
I'd like to help contribute migrating this project to React 15, and I think we could greatly reduce the amount of code necessary. For instance, right now the code is doing a ton of dependency injection since we don't have
screen
in scope. What if this library looked something like this instead?The text was updated successfully, but these errors were encountered: