Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

리팩터링 #140

Open
JuHyun419 opened this issue Jun 11, 2022 · 0 comments
Open

리팩터링 #140

JuHyun419 opened this issue Jun 11, 2022 · 0 comments
Labels
Refactoring

Comments

@JuHyun419
Copy link
Member

  • 기존 refactoring의 이슈인 fix refactoring의 경우 브랜치 명이 fix로 되어있기에 feature로 만들고자 이슈를 다시 만들었습니다.
JuHyun419 added a commit that referenced this issue Jun 18, 2022
@JuHyun419
[#140] chore: log 경로 수정
f1eeeda
JuHyun419 added a commit that referenced this issue Jun 18, 2022
@JuHyun419
[#140] chore: log 경로 수정
a31fe66
JuHyun419 added a commit that referenced this issue Jun 18, 2022
@JuHyun419
Merge pull request #141 from YAPP-19th/feature/#140-리팩터링
aceeb61 
[#140] log 경로 수정(테스트)
JuHyun419 added a commit that referenced this issue Jun 18, 2022
@JuHyun419
[#140] chore: logback 설정
377e0ca
JuHyun419 added a commit that referenced this issue Jun 20, 2022
@JuHyun419
[#140] refactor: 디렉토리 변경
0128084
JuHyun419 added a commit that referenced this issue Jun 20, 2022
@JuHyun419
[#140] chore: key 제거
4054020
Ji-Ha added a commit that referenced this issue Jun 20, 2022
@Ji-Ha
Merge pull request #142 from YAPP-19th/feature/#140-리팩터링
f20858c 
[#140] logback 설정
JuHyun419 added a commit that referenced this issue Jun 20, 2022
@JuHyun419
[#140] refactor: ObjectNotFoundException 패키지 수정
90fffb7
Ji-Ha added a commit that referenced this issue Jun 20, 2022
@Ji-Ha
Merge pull request #144 from YAPP-19th/feature/#140-리팩터링
b211659 
[#140] refactor: ObjectNotFoundException 패키지 수정
JuHyun419 added a commit that referenced this issue Jun 20, 2022
@JuHyun419
[#140] chore: EC2 ssh password 추가
e5e12a2
JuHyun419 added a commit that referenced this issue Jun 20, 2022
@JuHyun419
[#140] chore: EC2 ssh port 추가
8374396
Ji-Ha added a commit that referenced this issue Jun 20, 2022
@Ji-Ha
Merge pull request #145 from YAPP-19th/feature/#140-리팩터링
6f67f00 
[#140] ssh 설정 추가
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] refactor: 비밀번호 유효성 검증 로직 수정
88dec9c
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] refactor: 회원가입 URI Security 제외
04ecbfb
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] refactor: 로그 추가
a83a4ce
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] test: 테스트코드 속도 개선
d7705f8 
 - @WebMvcTest → 하나의 Context를 생성하여 사용하도록 동일한 의존성을 가지는 추상클래서 생성 및 상속
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] test: 테스트코드 속도 개선
19e4783 
 - @WebMvcTest → 하나의 Context를 생성하여 사용하도록 동일한 의존성을 가지는 추상클래서 생성 및 상속
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] test: 불필요한 코드 제거
9383fe5
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] test: 불필요한 코드 제거
36da53b
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] feat: 이전 PR 코드
76acda9
JuHyun419 added a commit that referenced this issue Jun 28, 2022
@JuHyun419
[#140] test: 의존 클래스 추가
685b180
JuHyun419 added a commit that referenced this issue Jun 29, 2022
@JuHyun419
[#140] test: conflict resolved 에서 삭제된 코드 추가
1ddcd0e
JuHyun419 added a commit that referenced this issue Jun 29, 2022
@JuHyun419
Merge pull request #156 from YAPP-19th/feature/#140-리팩터링
e2ba3e6 
[#140] 비밀번호 유효성 검증 로직 수정 및 테스트 코드 속도 개선
JuHyun419 added a commit that referenced this issue Jun 30, 2022
@JuHyun419
[#140] refactor: 로그인 시 등록 여부 변수 true로 변경
64278e2
Ji-Ha added a commit that referenced this issue Jul 1, 2022
@Ji-Ha
Merge pull request #159 from YAPP-19th/feature/#140-리팩터링
f677bb4 
[#140] refactor: 로그인 시 등록 여부 변수 true로 변경
JuHyun419 added a commit that referenced this issue Jul 1, 2022
@JuHyun419
Merge pull request #161 from YAPP-19th/develop
eec7d85 
[#140] 버그 수정
JuHyun419 added a commit that referenced this issue Jul 3, 2022
@JuHyun419
[#140] refactor: spring logback profile 에러 수정
5e22f8d
JuHyun419 added a commit that referenced this issue Jul 3, 2022
@JuHyun419
[#140] refactor: spring logback encoder 추가
4834664
JuHyun419 added a commit that referenced this issue Jul 3, 2022
@JuHyun419
[#140] test: 테스트 코드 추가
895de82
JuHyun419 added a commit that referenced this issue Jul 3, 2022
@JuHyun419
[#140] refactor: 기존에 작업된 코드로 변경
2c9ef32
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: 사용되지 않는 코드 제거
b3d667d
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: 로깅 추가, 로직 리팩터링, 메서드명 수정
2ee97b2
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: 메세지 문구 수정
f1df63e
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: Class layout order 수정
1b41895
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: 리마인드 관련 로직 수정(remind -> List<Remind>), 주석 추가
a2e280c
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] test: 구현 후 테스트 코드 수정
5c9152e
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: 불필요한 주석 제거
106639d
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: import asterisk(*) 삭제, 메서드명 변경
9de051e
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] feat: remind toggle 변경 메서드 추가
c4ec5b8
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] fix: Conflict Resolve & Merge 코드 추가
afb6f27
JuHyun419 added a commit that referenced this issue Aug 29, 2022
@JuHyun419
[#140] refactor: Remind 로직 임시 작성
12362e2
Ji-Ha added a commit that referenced this issue Aug 31, 2022
@Ji-Ha
Merge pull request #178 from YAPP-19th/feature/#140-리팩터링
c5057cd 
[#140] 리마인드 로직 수정 및 리팩터링
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: print 코드 제거
3213284
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: 리턴 타입 변경
f3104ad
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: FCM 발송 메서드에 @throws 추가
586d3dd
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: SlackService DI로 변경, Job Success 시 슬랙 알림 추가
0cc9c38
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: Job 리팩터링 및 로직 수정
c8f173e 
 - JOB, STEP Name 변수 추가
 - 구현체 -> 인터페이스 타입으로 변경
 - 로깅 추가
 - 북마크 내 리마인드 알림 발송하도록 로직 수정
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: toString 공백 추가
12a8c86
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: 리마인드 발송 대상 조회 로직 수정, FCM 발송 예외 처리,
92b3fed
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: 메서드명 수정
769f1f7
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: 로깅 수정 및 매직상수 제거
011716c
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: 예외처리 메시지 수정
e57c213
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: Job Completed 슬랙 알림 채널 변경
89f6238
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] refactor: 슬랙 알림 채널 추가(verbose)
ae2adcf
JuHyun419 added a commit that referenced this issue Sep 10, 2022
@JuHyun419
[#140] feat: 회원가입 시 회원 수 슬랙 알림 발송
e6aef3f
JuHyun419 added a commit that referenced this issue Sep 12, 2022
@JuHyun419
Merge pull request #179 from YAPP-19th/feature/#140-리팩터링
2a55e7d 
[#140] 리마인드 관련 리팩토링
JuHyun419 added a commit that referenced this issue Sep 18, 2022
@JuHyun419
[#140] refactor: 회원가입 알림 문구 수정 및 리마인드 주기 설정 API save 추가
addd278
JuHyun419 added a commit that referenced this issue Sep 20, 2022
@JuHyun419
Merge pull request #181 from YAPP-19th/feature/#140-리팩터링
2335e14 
리마인드 주기 설정 API 이슈 수정 및 알림 메시지 변경
JuHyun419 added a commit that referenced this issue Sep 20, 2022
@JuHyun419
Merge pull request #184 from YAPP-19th/develop
a7cacf4 
[#140] 슬랙 알림 메시지 수정, 리마인드 주기 설정 API 이슈 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JuHyun419