Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup: bump python & torch version #1098

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Setup: bump python & torch version #1098

merged 5 commits into from
Nov 26, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Nov 21, 2024 •
edited
Loading

Reason for this PR

Python 3.8 has reached EOL

Changes Made in this PR

Minimum python version is now 3.9

Testing Summary

N A

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser November 21, 2024 13:30
@Giuseppe5 Giuseppe5 changed the title Setup: bump python version Setup: bump python & torch version Nov 21, 2024
nickfraser
nickfraser reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment - should we use this moment to add some newer PT versions to the test suite?

.github/workflows/gen_github_actions.py Outdated Show resolved Hide resolved
@nickfraser
Copy link
Collaborator

Also, please close #959 when this gets merged.

@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser November 23, 2024 20:51
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser November 25, 2024 14:54
@Giuseppe5 Giuseppe5 merged commit ac0b5f5 into Xilinx:dev Nov 26, 2024
381 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser Awaiting requested review from nickfraser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser