-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich wires #523
base: develop
Are you sure you want to change the base?
Rich wires #523
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #523 +/- ##
===========================================
- Coverage 89.84% 89.78% -0.07%
===========================================
Files 93 93
Lines 6098 6089 -9
===========================================
- Hits 5479 5467 -12
- Misses 619 622 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Wires have been challenging to maintain due to evolving requirements.
This PR introduces a better abstraction for Wire that stores a collection of
QuantumWire
andClassicalWire
dataclasses. Metadata can be added to these dataclasses without modifying the Wires object’s handling of indices and dictionaries. Many methods, like__matmul__
, are greatly simplified.