-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Refactor #521
base: develop
Are you sure you want to change the base?
Batch Refactor #521
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #521 +/- ##
===========================================
- Coverage 89.81% 89.65% -0.17%
===========================================
Files 93 94 +1
Lines 6098 6158 +60
===========================================
+ Hits 5477 5521 +44
- Misses 621 637 +16
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Context: Currently in develop, there is no interface explicitly defined for the handling of batch dims. This makes things such as adding new batch dimensions (e.g. for measurement outcomes) difficult. Additionally, we wish to introduce the concept of "batch labels" where ideally some class is responsible for the handling of batch labels. As such, in this PR we introduce the
Batch
class.Description of the Change: Introduce the
Batch
class.Benefits: Having a concrete interface means a cleaner, safer implementation of batching where we can now define arbitrary batch dims and attribute batch labels to them (for mrm einsum).
TODO:
- ArrayAnsatz
- Everything working w arbitrary batch dims
- Handling of batch labels
- Improve ufunc as much as possible
- Cleanup
- Tests