Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Easy explorer access for accounts and hook objects #225

Closed
WietseWind opened this issue Jun 28, 2022 · 9 comments
Closed

[Suggestion] Easy explorer access for accounts and hook objects #225

WietseWind opened this issue Jun 28, 2022 · 9 comments

Comments

@WietseWind
Copy link
Member

In the Debug Stream, accounts are referenced:

image

When clicking on the account, it opens the account details panel:

image

It would be nice to be able to click the Hook hash & Account r-address and open the explorer. The explorer will figure out what you'r sending:
https://hooks-testnet-v2-explorer.xrpl-labs.com/raddress
https://hooks-testnet-v2-explorer.xrpl-labs.com/somehash (hook, tx, ..)

@vbar
Copy link
Collaborator

vbar commented Jun 28, 2022

note that linking the hook hash isn't quite compatible with #142 - but one of the links could have an extra icon, and #142 is backlog anyway...

@WietseWind
Copy link
Member Author

Thanks @vbar, will comment on #142 in that issue.

@valstu
Copy link
Collaborator

valstu commented Jun 29, 2022

Seems like /{hookhash} doesn't work, gives 404 🤔 On the explorer UI if you click hookhash it will redirect to /entry/{index}. Should I use similar logic @WietseWind?

@valstu
Copy link
Collaborator

valstu commented Jun 29, 2022

https://xrpl-hooks-ide-git-feat-links-to-explorer-xrpl-hooks.vercel.app/develop (#229) there's a preview of this feature, not sure if this is what you we're looking after?

@WietseWind
Copy link
Member Author

@valstu Interesting, do you have an example? I just tried one and it's working:
https://hooks-testnet-v2-explorer.xrpl-labs.com/BBF2D570816ED53B4A31954572E823A07501465DF8B32CCD20EBB97900B36828

Just checked the preview link, works like a charm, tx hash, r-address, hooks hash @ account panel:
image
All working :)

@valstu
Copy link
Collaborator

valstu commented Jun 29, 2022

Using your link as an example, I was trying to append the actual HookHash value A9B5411F4A4368008B4736EEE47A34B0EFCBE74016B9B94CC6208FBC0BF5C0C2 (from your link) to url which gave me 404

https://hooks-testnet-v2-explorer.xrpl-labs.com/A9B5411F4A4368008B4736EEE47A34B0EFCBE74016B9B94CC6208FBC0BF5C0C2

But figured out that I probably need to use the index value instead.

@WietseWind
Copy link
Member Author

WietseWind commented Jun 29, 2022

@valstu Ah that's a very good point. I will add that to the hash resolver right now so both will work.

Edit: done:
https://hooks-testnet-v2-explorer.xrpl-labs.com/A9B5411F4A4368008B4736EEE47A34B0EFCBE74016B9B94CC6208FBC0BF5C0C2

@valstu
Copy link
Collaborator

valstu commented Jun 30, 2022

Thanks 👏

@valstu
Copy link
Collaborator

valstu commented Jun 30, 2022

Merged #229

@valstu valstu closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants