Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Source and LoadBalancer #1621

Open
kuznetsss opened this issue Sep 3, 2024 · 0 comments
Open

Refactor Source and LoadBalancer #1621

kuznetsss opened this issue Sep 3, 2024 · 0 comments
Labels
refactoring Code improvements without logical changes
Milestone
2.5

Comments

@kuznetsss
Copy link
Collaborator

Currently Source in etl just holds SubscriptionSource, GrpcSource and ForwardingSource. It is a bad design to have proxy classes so Source could be refactored to provide a direct access to all the underlying sources instead of proxying their methods.

Also currently it is not very convenient for tests that LoadBalancer creates all the sources in constructor from config file. It would be better for LoadBalancer to have a method addSource() and another method make_LoadBalancer() creating all sources from config and adding them to LoadBalancer.
@kuznetsss kuznetsss added the refactoring Code improvements without logical changes label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Sep 3, 2024
@godexsoft godexsoft added this to the 2.4 milestone Sep 23, 2024
@kuznetsss kuznetsss modified the milestones: 2.4, 2.5 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvements without logical changes
Projects
Clio
Status: 📋 Backlog
Milestone
2.5
Development

No branches or pull requests
2 participants
@godexsoft @kuznetsss