Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DynamicNFT XLS-46 #1471

Open
cindyyan317 opened this issue Jun 18, 2024 · 1 comment · May be fixed by #1525
Open

Support DynamicNFT XLS-46 #1471

cindyyan317 opened this issue Jun 18, 2024 · 1 comment · May be fixed by #1525
Labels
future Future ideas and plans
Milestone

Comments

@cindyyan317
Copy link
Collaborator

cindyyan317 commented Jun 18, 2024

Clio has an index table nf_token_uris to store the uri. Since the URI is changeable for XLS-46 , we need to update our logic to support.

@cindyyan317 cindyyan317 added the enhancement New feature or request label Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Jun 18, 2024
@cindyyan317 cindyyan317 added the future Future ideas and plans label Jun 18, 2024
@godexsoft godexsoft added this to the 2.4 milestone Jun 18, 2024
@cindyyan317 cindyyan317 removed the enhancement New feature or request label Jun 18, 2024
@shawnxie999
Copy link
Collaborator

shawnxie999 commented Jun 20, 2024

There might be an edge case that could result in data loss. If NFTokenModify and NFTokenCreateOffer/NFTokenAcceptOffer occur in the same ledger, then the newest URI may not be stored. This is because the ETL sorts the NFT transactions in the order of their occurrence, and then only keeps the NFT data from the last transaction, which means that whatever data NFTokenModify wants to store is always discarded.

This should be looked into and checked. If it's the case, then we may potentially need to update the NFT ETL to store URI every time NFTokenCreateOffer/NFTokenAcceptOffer happens (currently, only NFTokenMint stores URI). There might be other solutions.

@kennyzlei kennyzlei linked a pull request Aug 6, 2024 that will close this issue
@kuznetsss kuznetsss modified the milestones: 2.4, 2.5 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Future ideas and plans
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants