Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for images instead of icons in the main menu #788

Open
Zodiac1978 opened this issue Nov 13, 2024 · 0 comments
Open

Add a check for images instead of icons in the main menu #788

Zodiac1978 opened this issue Nov 13, 2024 · 0 comments

Comments

@Zodiac1978
Copy link

I know this is a chicken-and-egg-problem.

2020 I asked for a rule to disallow images in the main menu:
WordPress/wporg-plugin-guidelines#71

It was closed because it wouldn't be enforceable.

Maybe adding this to the plugin check plugin could be a start to at least recommend not using images, as they are often conflicting with one of the possible color schemes.

Best practice would be to use a dashicon or a custom SVG that will use the color from the color scheme used.

If you only want to add checks stated in the guidelines, but the guidelines don't want to add them, because they are not enforceable, we will have no progress here.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant