Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License check improvements #746

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

License check improvements #746

wants to merge 3 commits into from

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Oct 25, 2024 •
edited
Loading

Fixes #737

  • Add License_Utils trait
  • New trait is used in Plugin_Readme_Check and Plugin_Header_Fields_Check
  • Add new error codes: plugin_header_no_license and plugin_header_invalid_license (Earlier same error code no_license was used for missing license in readme and plugin header which is confusing)
  • license_mismatch error code is moved from Plugin_Readme_Check to Plugin_Header_Fields_Check
  • Update unit tests to reflect changes
  • Add unit test for invalid license
  • Add scenario for missing license in single file plugin

@ernilambar ernilambar force-pushed the update-license branch 13 times, most recently from c7b680b to 7a73b21 Compare October 25, 2024 16:54
@ernilambar ernilambar changed the title WIP: Update license check License check improvements Oct 25, 2024
@ernilambar ernilambar marked this pull request as ready for review October 25, 2024 17:31
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Oct 29, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Oct 29, 2024
@ernilambar ernilambar marked this pull request as draft October 30, 2024 08:19
@ernilambar ernilambar removed this from the 1.3.0 milestone Oct 30, 2024
@ernilambar
Copy link
Member Author

ernilambar commented Oct 30, 2024 •
edited
Loading

This PR is getting bigger and bigger. So I have created separate PR for license check infrastructure. Will work on this PR after rebasing after #761 is merged and #762 is finalized.

@davidperezgar
Copy link
Member

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@davidperezgar davidperezgar Awaiting requested review from davidperezgar davidperezgar is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error no_license not triggered with missing readme file
2 participants
@ernilambar @davidperezgar